Changed environment config loading from array_merge() to array_replace_recursive()

[ChuckHeintzelman]

Small change when loading environment specific configurations. Now the code below will merge the username/password into database connections array instead of replacing it entirely.

<?php
// my app/config/local/database.php
return array(
    'connections' => array(
        'mysql' => array(
            'username' => 'myname',
            'password' => 'mypass',
        ),
    ),
);

[taylorotwell]

This is not the desired behavior and actually breaks config loading.

[taylorotwell]

Err, thought you said array_merge_recursive. Sorry, will look at this later.

[ChuckHeintzelman]

Yes. array_merge_recursive() would break things. Here's a blog post illustrating the difference. http://jontai.me/blog/2011/12/array_merge_recursive-vs-array_replace_recursive/

[bencorlett]

This is the exact same pull as #757 FYI @taylorotwell

[bencorlett]

Having said that, I kinda like it and I do use it in my composite config package (which cascades config from the database).

[ChuckHeintzelman]

Dang! I even searched for a previous pull request.

[taylorotwell]

Yeah this seems to work well. I must have been making the same mistake in the previous pull request.

[ChuckHeintzelman]

Add <?php as the first line of your app/config/local/database.php and that should fix it.