Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] make artisan workbench remember last email/name entered. #64

Closed
iccle opened this issue Jan 16, 2013 · 11 comments
Closed

[Request] make artisan workbench remember last email/name entered. #64

iccle opened this issue Jan 16, 2013 · 11 comments

Comments

@iccle
Copy link

iccle commented Jan 16, 2013

I would love to see thee artisan workbench command remember the last email and name entered to save me having to re-enter these details each time i create a package, or optionally to load these from a config file.

@jasonlewis
Copy link
Contributor

Honestly I think that's just lazy. ⛵

See what others think though.

@iccle
Copy link
Author

iccle commented Jan 16, 2013

I guess if your only writing a single package, i was just thinking it would be nice not to have to enter the same information again and again.

@jasonlewis
Copy link
Contributor

Copy paste! :)

@frankmayer
Copy link

I agree with @jasonlewis that it's kind of very low priority, if at all.
Having said that, it's kind of lazy, but aren't we all? :D
If we weren't, there wouldn't be code completion in editors, etc... ;)
I haven't dived into artisan commands yet, but couldn't this functionality be a separate package, if not in the base distribution? Maybe @iccle could implement that?

@franzliedke
Copy link
Contributor

I remember seeing an issue about adding a config file with default values for name and email - that would probably be an easier way and would still fulfill your need, right?

@daylerees
Copy link
Contributor

Hmmm, can't imagine this being a priority.

@iccle
Copy link
Author

iccle commented Jan 16, 2013

I didnt expect it to be priorty, and dont think its particularly lazy i prefer to enter data once and re-use it instead of re-entering it.

My thinking was how often do i change my name or email? Never. So it would be nice for workbench to remember me saving me from pesky typos as i repeatedly enter my information. This could be extended to store your favorite licence choice for your composer.json.

Other artisan commands may benefit from some sort of persistant/global config, eg it would be nice to set the default namespace used for controllers once (for my project or whatever) then have commands that use --namespace read it in if no namespace is specified on the command line.

Im still feeling my way around the new code, may look into making something like this once i find my feet.

@patrickheeney
Copy link

I think this is a great idea. I think it just needs to be a simple config file. Artisan would first check if the config file exists and use those settings unless overridden in the command. If no config file or not in the command then prompt for it.

As iccle mentions, other commands could benefit from this. For example migrate:make, you could change the path from app/migrations and not have to retype it every time. New packages could install config defaults for commands as well. For example with laravel-bob bundle you could always have bob controller use --blade and --restful.

Definitely not high priority, however Its the little things that make laravel so great.

@Anahkiasen
Copy link
Contributor

+1 on making it a config entry.

@GaryJones
Copy link

Since your typing / config files for name and emails are just populating stubs, could Artisan not be made to check a custom stubs directory outside of all projects for all of its commands. You could then also configure, for instance, phpunit.xml not to have colors set to true (as that makes it all screwy in Windows), have the service provider and controller stubs start off as PSR-2, custom travis config etc.?

@taylorotwell
Copy link
Member

This is implemented via the new workbench configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants