BackedEnum on Route already resolved

[CAAHS]

Laravel Version

10.48.11

PHP Version

8.1.28

Database Driver & Version

No response

Description

Given the $parameterValue on the route is already resolved, do not try to resolve it from stringable any longer.

Otherwise an error (current behavior):

 Object of class App\Models\StringBackedEnum could not be converted to string

Error occured first during an update of livewire/livewire:

Production Changes	From	To	Compare
livewire/livewire	v3.3.0	v3.3.1	...

(isolated change, from livewire/livewire:v3.3.1...latest the error retains)

$ artisan --version
Laravel Framework 10.48.11

We have a trivial patch in \Illuminate\Routing\ImplicitRouteBinding::resolveBackedEnumsForRoute:

diff --git a/vendor/laravel/framework/src/Illuminate/Routing/ImplicitRouteBinding.php b/vendor/laravel/framework/src/Illuminate/Routing/ImplicitRouteBindingB.php
index d3590de..04921e0 100644
--- a/vendor/laravel/framework/src/Illuminate/Routing/ImplicitRouteBinding.php
+++ b/vendor/laravel/framework/src/Illuminate/Routing/ImplicitRouteBindingB.php
@@ -86,7 +86,13 @@ class ImplicitRouteBinding
 
             $backedEnumClass = $parameter->getType()?->getName();
 
-            $backedEnum = $backedEnumClass::tryFrom((string) $parameterValue);
+            $backedEnum = null;
+
+            if ($parameterValue instanceof $backedEnumClass) {
+                $backedEnum = $parameterValue;
+            }
+
+            $backedEnum = $backedEnum ?? $backedEnumClass::tryFrom((string) $parameterValue);
 
             if (is_null($backedEnum)) {
                 throw new BackedEnumCaseNotFoundException($backedEnumClass, $parameterValue);

and do see this is induced by Livewire.

From the type of change we believe this is a good fit for supporting (String)BackedEnums on Routes.

Please let us know if this is not too far off, then we would create a pull request.

Please share your recommendations.

Steps To Reproduce

• Wire a route with a backed enum parameter

• Inject the enum, directly or indirectly (e.g. use Livewire)

• Error throws at vendor/laravel/framework/src/Illuminate/Routing/ImplicitRouteBinding.php:89

  $backedEnum = $backedEnumClass::tryFrom((string) $parameterValue);
                                                  ^
                                                  |
             /!\ Object of class App\Models\StringBackedEnum could not be converted to string
  

[crynobone]

Should be able to backport #51525 to 10.x branch

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

[CAAHS]

Should be able to backport #51525 to 10.x branch

Thanks for the pointers. Looks like the exact same change. We were able to file a PR or two, this is the open one: #51586 @crynobone