whereHasMorph generates wrong sql in whereHas Callback

[Zepryit]

• Laravel Version: 8.19.0
• PHP Version: 7.4.2
• Database Driver & Version: MariaDB 10.5.8

Description:

The use of whereHasMorph in a whereHas callback generates a wrong sql statements. A call to the whereHasMorph outside of a whereHas callback works fine.
The sql generated by the whereHas-whereHasMorph combination:

select * from `planning_contexts` where exists (
    select * from `planning_contexts` as `laravel_reserved_0` where `planning_contexts`.`context_id` = `laravel_reserved_0`.`context_id` and (
       (
            /* --- This is the wrong sql --- */
            `planning_contexts` as `laravel_reserved_0.plannable_type` = ? 
            /* ------------------------------ */
            and exists (
                select * from `versions` where `laravel_reserved_0`.`plannable_id` = `versions`.`id` and `published_at` = ?)
       )
   )
) order by `context_id` asc

Steps To Reproduce:

The PlanningContext class

class PlanningContext extends Model {
    /**
      * The relation which is used by the whereHas.
      * 
      * @return HasMany
      */
    public function relatedPlanningContexts(): HasMany {
        return $this->hasMany(PlanningContext::class, 'context_id', 'context_id');
    }

    /**
      * The realtion which is used by the whereHasMorph
      * 
      * @return MorphTo
      */
    public function plannable(): MorphTo {
        return $this->morphTo('plannable');
    }
}

The code which reproduces the error:

PlanningContext::whereHas('relatedPlanningContexts', function (Builder $query) {
    $query->whereHasMorph('plannable', [Version::class], function (Builder $q) {
        $q->where('published_at', Version::max('published_at'));
    });
})->orderBy('context_id', 'ASC')->paginate(100);

[taylorotwell]

Feel free to PR a fix. I probably won't spend any time myself digging into this.

[taylorotwell]

Also your query is a bit confusing - you have whereHasMorph('plannable') nested in the whereHas query callback but you have plannable listed on the PlanningContext model - so why is it nested within the whereHas?

[Zepryit]

The PlanningContext has a relation to itself by a context_id this defines an entry in a planning grid. And the polymorphic relation defines what entities are planned with each other.

E.g. I have one PlanningContext connected to a User, one to a Station, and one to a Version of the plan. These PlanningContexts are related by their context_id which means the User is planned at the Station in this Version of the plan.

When I want to show all entries of a specific Version, in this case the latest, i need to find all PlanningContexts with a connection to another PlanningContext which is connected to the specific Version.

I am also not sure if this is the best approach for my project. I am still researching.

I have already tried to find the issue but with no success yet. But i will give it another try in my free time.

[staudenmeir]

We need to adjust $this->query->from.'.'.$relation->getMorphType() in:

framework/src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php

Line 226 in aec5cca

$query->where($this->query->from.'.'.$relation->getMorphType(), '=', (new $type)->getMorphClass())

I see two options:

• $this->qualifyColumn($relation->getMorphType())
• last(preg_split('/\s+as\s+/i', $this->query->from)).'.'.$relation->getMorphType()

The first one would be more elegant, but I'm not sure if it works with all edge cases.

[driesvints]

Anyone up for PR'ing the above?

[selcukcukur]

Fixed with pull request #36801 can be closed. @driesvints

[driesvints]

@selcukcukur thanks!