[10.x] Fix issues with updated_at (#48230)

* wip * wip
laravel · Aug 29, 2023 · d3b981b · d3b981b
1 parent b40d6be
commit d3b981b
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 1 deletion.
diff --git a/src/Illuminate/Database/Eloquent/Builder.php b/src/Illuminate/Database/Eloquent/Builder.php
@@ -1166,7 +1166,7 @@ protected function addUpdatedAtColumn(array $values)
             ) {
                 $timestamp = $this->model->newInstance()
                     ->forceFill([$column => $timestamp])
-                    ->getAttributes()[$column];
+                    ->getAttributes()[$column] ?? $timestamp;
             }
 
             $values = array_merge([$column => $timestamp], $values);

diff --git a/tests/Integration/Database/MySql/EloquentCastTest.php b/tests/Integration/Database/MySql/EloquentCastTest.php
@@ -20,6 +20,13 @@ protected function defineDatabaseMigrationsAfterDatabaseRefreshed()
             $table->integer('created_at');
             $table->integer('updated_at');
         });
+
+        Schema::create('users_nullable_timestamps', function ($table) {
+            $table->increments('id');
+            $table->string('email')->unique();
+            $table->timestamp('created_at')->nullable();
+            $table->timestamp('updated_at')->nullable();
+        });
     }
 
     protected function destroyDatabaseMigrations()
@@ -115,6 +122,27 @@ public function testItCastTimestampsCreatedByTheBuilderWhenTimeHasPassed()
         $this->assertSame($updatedAt, $mutatorUser->updated_at->timestamp);
         $this->assertSame($updatedAt, $mutatorUser->fresh()->updated_at->timestamp);
     }
+
+    public function testItCastTimestampsUpdatedByAMutator()
+    {
+        Carbon::setTestNow(now());
+
+        $mutatorUser = UserWithUpdatedAtViaMutator::create([
+            'email' => fake()->unique()->email,
+        ]);
+
+        $this->assertNull($mutatorUser->updated_at);
+
+        Carbon::setTestNow(now()->addSecond());
+        $updatedAt = now()->timestamp;
+
+        $mutatorUser->update([
+            'email' => fake()->unique()->email,
+        ]);
+
+        $this->assertSame($updatedAt, $mutatorUser->updated_at->timestamp);
+        $this->assertSame($updatedAt, $mutatorUser->fresh()->updated_at->timestamp);
+    }
 }
 
 class UserWithIntTimestampsViaCasts extends Model
@@ -191,3 +219,19 @@ protected function setCreatedAtAttribute($value)
         $this->attributes['created_at'] = Carbon::parse($value)->timestamp;
     }
 }
+
+class UserWithUpdatedAtViaMutator extends Model
+{
+    protected $table = 'users_nullable_timestamps';
+
+    protected $fillable = ['email', 'updated_at'];
+
+    public function setUpdatedAtAttribute($value)
+    {
+        if (! $this->id) {
+            return;
+        }
+
+        $this->updated_at = $value;
+    }
+}