Extract methods

src/Illuminate/Foundation/Console/RouteCacheCommand.php

@@ -6,9 +6,6 @@
 use Illuminate\Contracts\Console\Kernel as ConsoleKernelContract;
 use Illuminate\Filesystem\Filesystem;
 use Illuminate\Routing\RouteCollection;
-use Illuminate\Support\Str;
-use Symfony\Component\Routing\Matcher\Dumper\CompiledUrlMatcherDumper;
-use Symfony\Component\Routing\RouteCollection as SymfonyRouteCollection;
 
 class RouteCacheCommand extends Command
 {
@@ -61,24 +58,11 @@ public function handle()
             return $this->error("Your application doesn't have any routes.");
         }
 
-        $symfonyRoutes = new SymfonyRouteCollection();
-
-        foreach ($routes as &$route) {
+        foreach ($routes as $route) {
             $route->prepareForSerialization();
-
-            // If the route doesn't have a name, we'll generate one for it
-            // and re-add the route to the collection. This way we can
-            // add the route to the Symfony route collection.
-            if (! $name = $route->getName()) {
-                $route->name($name = Str::random());
-
-                $routes->add($route);
-            }
-
-            $symfonyRoutes->add($name, $route->toSymfonyRoute());
         }
 
-        $compiled = (new CompiledUrlMatcherDumper($symfonyRoutes))->getCompiledRoutes();
+        $compiled = $routes->dumper()->getCompiledRoutes();
 
         $this->files->put(
             $this->laravel->getCachedRoutesPath(),

src/Illuminate/Routing/RouteCollection.php

@@ -7,11 +7,14 @@
 use Illuminate\Http\Request;
 use Illuminate\Http\Response;
 use Illuminate\Support\Arr;
+use Illuminate\Support\Str;
 use IteratorAggregate;
 use Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Symfony\Component\Routing\Matcher\CompiledUrlMatcher;
+use Symfony\Component\Routing\Matcher\Dumper\CompiledUrlMatcherDumper;
 use Symfony\Component\Routing\RequestContext;
+use Symfony\Component\Routing\RouteCollection as SymfonyRouteCollection;
 
 class RouteCollection implements Countable, IteratorAggregate
 {
@@ -396,4 +399,41 @@ public function count()
     {
         return count($this->getRoutes());
     }
+
+    /**
+     * Return the CompiledUrlMatcherDumper instance for the route collection.
+     *
+     * @return \Symfony\Component\Routing\Matcher\Dumper\CompiledUrlMatcherDumper
+     */
+    public function dumper()
+    {
+        return new CompiledUrlMatcherDumper($this->toSymfonyRouteCollection());
+    }
+
+    /**
+     * Convert the collection to a Symfony RouteCollection instance.
+     *
+     * @return \Symfony\Component\Routing\RouteCollection
+     */
+    public function toSymfonyRouteCollection()
+    {
+        $symfonyRoutes = new SymfonyRouteCollection();
+
+        foreach ($this->getRoutes() as $route) {
+            // If the route doesn't have a name, we'll generate one for it
+            // and re-add the route to the collection. This way we can
+            // add the route to the Symfony route collection.
+            if (! $name = $route->getName()) {
+                $route->name($name = Str::random());
+
+                $this->add($route);
+            }
+
+            $symfonyRoutes->add($name, $route->toSymfonyRoute());
+        }
+
+        $this->refreshNameLookups();
+
+        return $symfonyRoutes;
+    }
 }