Revert "[11.x] Support DB aggregate by group (#53209)" (#53582)

This reverts commit 6a491c2.
laravel · Nov 19, 2024 · 91e9de0 · 91e9de0
1 parent 11508cd
commit 91e9de0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 102 deletions.
diff --git a/src/Illuminate/Database/Query/Builder.php b/src/Illuminate/Database/Query/Builder.php
@@ -3554,20 +3554,18 @@ public function doesntExistOr(Closure $callback)
      * Retrieve the "count" result of the query.
      *
      * @param  \Illuminate\Contracts\Database\Query\Expression|string  $columns
-     * @return \Illuminate\Support\Collection|int
+     * @return int
      */
     public function count($columns = '*')
     {
-        $results = $this->aggregate(__FUNCTION__, Arr::wrap($columns));
-
-        return $results instanceof Collection ? $results : (int) $results;
+        return (int) $this->aggregate(__FUNCTION__, Arr::wrap($columns));
     }
 
     /**
      * Retrieve the minimum value of a given column.
      *
      * @param  \Illuminate\Contracts\Database\Query\Expression|string  $column
-     * @return \Illuminate\Support\Collection|mixed
+     * @return mixed
      */
     public function min($column)
     {
@@ -3578,7 +3576,7 @@ public function min($column)
      * Retrieve the maximum value of a given column.
      *
      * @param  \Illuminate\Contracts\Database\Query\Expression|string  $column
-     * @return \Illuminate\Support\Collection|mixed
+     * @return mixed
      */
     public function max($column)
     {
@@ -3589,7 +3587,7 @@ public function max($column)
      * Retrieve the sum of the values of a given column.
      *
      * @param  \Illuminate\Contracts\Database\Query\Expression|string  $column
-     * @return \Illuminate\Support\Collection|mixed
+     * @return mixed
      */
     public function sum($column)
     {
@@ -3602,7 +3600,7 @@ public function sum($column)
      * Retrieve the average of the values of a given column.
      *
      * @param  \Illuminate\Contracts\Database\Query\Expression|string  $column
-     * @return \Illuminate\Support\Collection|mixed
+     * @return mixed
      */
     public function avg($column)
     {
@@ -3613,7 +3611,7 @@ public function avg($column)
      * Alias for the "avg" method.
      *
      * @param  \Illuminate\Contracts\Database\Query\Expression|string  $column
-     * @return \Illuminate\Support\Collection|mixed
+     * @return mixed
      */
     public function average($column)
     {
@@ -3625,7 +3623,7 @@ public function average($column)
      *
      * @param  string  $function
      * @param  array  $columns
-     * @return \Illuminate\Support\Collection|mixed
+     * @return mixed
      */
     public function aggregate($function, $columns = ['*'])
     {
@@ -3634,10 +3632,6 @@ public function aggregate($function, $columns = ['*'])
                         ->setAggregate($function, $columns)
                         ->get($columns);
 
-        if ($this->groups) {
-            return $results;
-        }
-
         if (! $results->isEmpty()) {
             return array_change_key_case((array) $results[0])['aggregate'];
         }

diff --git a/src/Illuminate/Database/Query/Grammars/Grammar.php b/src/Illuminate/Database/Query/Grammars/Grammar.php
@@ -138,15 +138,7 @@ protected function compileAggregate(Builder $query, $aggregate)
             $column = 'distinct '.$column;
         }
 
-        $sql = 'select ';
-
-        if ($query->groups) {
-            $sql .= $this->columnize($query->groups).', ';
-        }
-
-        $sql .= $aggregate['function'].'('.$column.') as aggregate';
-
-        return $sql;
+        return 'select '.$aggregate['function'].'('.$column.') as aggregate';
     }
 
     /**
@@ -1138,12 +1130,10 @@ protected function wrapUnion($sql)
     protected function compileUnionAggregate(Builder $query)
     {
         $sql = $this->compileAggregate($query, $query->aggregate);
-        $groups = $query->groups ? ' '.$this->compileGroups($query, $query->groups) : '';
 
         $query->aggregate = null;
-        $query->groups = null;
 
-        return $sql.' from ('.$this->compileSelect($query).') as '.$this->wrapTable('temp_table').$groups;
+        return $sql.' from ('.$this->compileSelect($query).') as '.$this->wrapTable('temp_table');
     }
 
     /**

diff --git a/tests/Database/DatabaseQueryBuilderTest.php b/tests/Database/DatabaseQueryBuilderTest.php
@@ -25,7 +25,6 @@
 use Illuminate\Pagination\Cursor;
 use Illuminate\Pagination\CursorPaginator;
 use Illuminate\Pagination\LengthAwarePaginator;
-use Illuminate\Support\Collection;
 use Illuminate\Tests\Database\Fixtures\Enums\Bar;
 use InvalidArgumentException;
 use Mockery as m;
@@ -1805,36 +1804,6 @@ public function testGroupBys()
         $this->assertEquals(['whereRawBinding', 'groupByRawBinding', 'havingRawBinding'], $builder->getBindings());
     }
 
-    public function testGroupByAndAggregate()
-    {
-        $builder = $this->getBuilder();
-
-        $queryResults = [['aggregate' => 2, 'role' => 'admin', 'city' => 'NY'], ['aggregate' => 5, 'role' => 'user', 'city' => 'LA']];
-        $builder->getConnection()
-            ->shouldReceive('select')->once()
-            ->with('select "role", "city", count(*) as aggregate from "users" group by "role", "city"', [], true)
-            ->andReturn($queryResults);
-        $builder->getProcessor()->shouldReceive('processSelect')->once()->andReturnUsing(fn ($builder, $results) => $results);
-        $results = $builder->from('users')->groupBy('role', 'city')->aggregate('count');
-        $this->assertEquals($queryResults, $results->toArray());
-    }
-
-    public function testGroupByUnionAndAggregate()
-    {
-        $builder = $this->getBuilder();
-
-        $queryResults = [['aggregate' => 2, 'role' => 'admin'], ['aggregate' => 5, 'role' => 'user']];
-        $builder->getConnection()
-            ->shouldReceive('select')->once()
-            ->with('select "role", count(*) as aggregate from ((select * from "users") union (select * from "members")) as "temp_table" group by "role"', [], true)
-            ->andReturn($queryResults);
-        $builder->getProcessor()->shouldReceive('processSelect')->once()->andReturnUsing(fn ($builder, $results) => $results);
-        $results = $builder->from('users')
-            ->union($this->getBuilder()->select('*')->from('members'))
-            ->groupBy('role')->aggregate('count');
-        $this->assertEquals($queryResults, $results->toArray());
-    }
-
     public function testOrderBys()
     {
         $builder = $this->getBuilder();
@@ -3495,51 +3464,6 @@ public function testAggregateFunctions()
         $this->assertEquals(1, $results);
     }
 
-    public function testAggregateFunctionsWithGroupBy()
-    {
-        $builder = $this->getBuilder();
-        $builder->getConnection()->shouldReceive('select')->once()->with('select "role", count(*) as aggregate from "users" group by "role"', [], true)->andReturn([['role' => 'admin', 'aggregate' => 1]]);
-        $builder->getProcessor()->shouldReceive('processSelect')->once()->andReturnUsing(fn ($builder, $results) => $results);
-        $results = $builder->from('users')->groupBy('role')->count();
-        $this->assertInstanceOf(Collection::class, $results);
-        $this->assertEquals([['role' => 'admin', 'aggregate' => 1]], $results->toArray());
-
-        $builder = $this->getBuilder();
-        $builder->getConnection()->shouldReceive('select')->once()->with('select "role", max("id") as aggregate from "users" group by "role"', [], true)->andReturn([['role' => 'admin', 'aggregate' => 1]]);
-        $builder->getProcessor()->shouldReceive('processSelect')->once()->andReturnUsing(fn ($builder, $results) => $results);
-        $results = $builder->from('users')->groupBy('role')->max('id');
-        $this->assertInstanceOf(Collection::class, $results);
-        $this->assertEquals([['role' => 'admin', 'aggregate' => 1]], $results->toArray());
-
-        $builder = $this->getBuilder();
-        $builder->getConnection()->shouldReceive('select')->once()->with('select "role", min("id") as aggregate from "users" group by "role"', [], true)->andReturn([['role' => 'admin', 'aggregate' => 1]]);
-        $builder->getProcessor()->shouldReceive('processSelect')->once()->andReturnUsing(fn ($builder, $results) => $results);
-        $results = $builder->from('users')->groupBy('role')->min('id');
-        $this->assertInstanceOf(Collection::class, $results);
-        $this->assertEquals([['role' => 'admin', 'aggregate' => 1]], $results->toArray());
-
-        $builder = $this->getBuilder();
-        $builder->getConnection()->shouldReceive('select')->once()->with('select "role", sum("id") as aggregate from "users" group by "role"', [], true)->andReturn([['role' => 'admin', 'aggregate' => 1]]);
-        $builder->getProcessor()->shouldReceive('processSelect')->once()->andReturnUsing(fn ($builder, $results) => $results);
-        $results = $builder->from('users')->groupBy('role')->sum('id');
-        $this->assertInstanceOf(Collection::class, $results);
-        $this->assertEquals([['role' => 'admin', 'aggregate' => 1]], $results->toArray());
-
-        $builder = $this->getBuilder();
-        $builder->getConnection()->shouldReceive('select')->once()->with('select "role", avg("id") as aggregate from "users" group by "role"', [], true)->andReturn([['role' => 'admin', 'aggregate' => 1]]);
-        $builder->getProcessor()->shouldReceive('processSelect')->once()->andReturnUsing(fn ($builder, $results) => $results);
-        $results = $builder->from('users')->groupBy('role')->avg('id');
-        $this->assertInstanceOf(Collection::class, $results);
-        $this->assertEquals([['role' => 'admin', 'aggregate' => 1]], $results->toArray());
-
-        $builder = $this->getBuilder();
-        $builder->getConnection()->shouldReceive('select')->once()->with('select "role", avg("id") as aggregate from "users" group by "role"', [], true)->andReturn([['role' => 'admin', 'aggregate' => 1]]);
-        $builder->getProcessor()->shouldReceive('processSelect')->once()->andReturnUsing(fn ($builder, $results) => $results);
-        $results = $builder->from('users')->groupBy('role')->average('id');
-        $this->assertInstanceOf(Collection::class, $results);
-        $this->assertEquals([['role' => 'admin', 'aggregate' => 1]], $results->toArray());
-    }
-
     public function testSqlServerExists()
     {
         $builder = $this->getSqlServerBuilder();