Skip to content

Commit

Permalink
[8.x] Remove redundant description & localize template (#39928)
Browse files Browse the repository at this point in the history
* Remove redundant description

Screen readers will announce the type of role the landmark is, in this case screen readers would say "Pagination Navigation Navigation" -- this commit fixes that.

See also "Redundant descriptions" @ mdn: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/form_role

* Localize and remove redundant description

Screen readers will announce the type of role the landmark is, in this case screen readers would say "Pagination Navigation Navigation" -- this commit fixes that.

See also "Redundant descriptions" @ mdn: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/form_role
  • Loading branch information
xanderificnl authored Dec 8, 2021
1 parent 57311eb commit 608c430
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@if ($paginator->hasPages())
<nav role="navigation" aria-label="Pagination Navigation" class="flex justify-between">
<nav role="navigation" aria-label="{{ __('Pagination') }}" class="flex justify-between">
{{-- Previous Page Link --}}
@if ($paginator->onFirstPage())
<span class="relative inline-flex items-center px-4 py-2 text-sm font-medium text-gray-500 bg-white border border-gray-300 cursor-default leading-5 rounded-md">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@if ($paginator->hasPages())
<nav role="navigation" aria-label="{{ __('Pagination Navigation') }}" class="flex items-center justify-between">
<nav role="navigation" aria-label="{{ __('Pagination') }}" class="flex items-center justify-between">
<div class="flex justify-between flex-1 sm:hidden">
@if ($paginator->onFirstPage())
<span class="relative inline-flex items-center px-4 py-2 text-sm font-medium text-gray-500 bg-white border border-gray-300 cursor-default leading-5 rounded-md">
Expand Down

0 comments on commit 608c430

Please sign in to comment.