Avoid undefined array key 0 error (#40571)

laravel · Jan 24, 2022 · 4bffc87 · 4bffc87
1 parent 60d60b0
commit 4bffc87
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/src/Illuminate/Redis/Connections/PhpRedisClusterConnection.php b/src/Illuminate/Redis/Connections/PhpRedisClusterConnection.php
@@ -13,7 +13,7 @@ public function flushdb()
     {
         $arguments = func_get_args();
 
-        $async = strtoupper((string) $arguments[0] ?? null) === 'ASYNC';
+        $async = strtoupper((string) ($arguments[0] ?? null)) === 'ASYNC';
 
         foreach ($this->client->_masters() as $master) {
             $async

diff --git a/src/Illuminate/Redis/Connections/PhpRedisConnection.php b/src/Illuminate/Redis/Connections/PhpRedisConnection.php
@@ -500,7 +500,7 @@ public function flushdb()
     {
         $arguments = func_get_args();
 
-        if (strtoupper((string) $arguments[0] ?? null) === 'ASYNC') {
+        if (strtoupper((string) ($arguments[0] ?? null)) === 'ASYNC') {
             return $this->command('flushdb', [true]);
         }
 

diff --git a/tests/Redis/RedisConnectionTest.php b/tests/Redis/RedisConnectionTest.php
@@ -467,6 +467,28 @@ public function testItGetsMultipleKeys()
         }
     }
 
+    public function testItFlushes()
+    {
+        foreach ($this->connections() as $redis) {
+            $redis->set('name', 'Till');
+            $this->assertSame(1, $redis->exists('name'));
+
+            $redis->flushdb();
+            $this->assertSame(0, $redis->exists('name'));
+        }
+    }
+
+    public function testItFlushesAsynchronous()
+    {
+        foreach ($this->connections() as $redis) {
+            $redis->set('name', 'Till');
+            $this->assertSame(1, $redis->exists('name'));
+
+            $redis->flushdb('ASYNC');
+            $this->assertSame(0, $redis->exists('name'));
+        }
+    }
+
     public function testItRunsEval()
     {
         foreach ($this->connections() as $redis) {