formatting and add test

laravel · Apr 19, 2020 · 44c2a8d · 44c2a8d
1 parent 6aa80e7
commit 44c2a8d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/Illuminate/Container/BoundMethod.php b/src/Illuminate/Container/BoundMethod.php
@@ -171,7 +171,7 @@ protected static function addDependencyForCallParameter($container, $parameter,
         } elseif ($parameter->isDefaultValueAvailable()) {
             $dependencies[] = $parameter->getDefaultValue();
         } elseif (! $parameter->isOptional() && ! array_key_exists($parameter->name, $parameters)) {
-            $message = "Unresolvable dependency resolving [$parameter] in class {$parameter->getDeclaringClass()->getName()}";
+            $message = "Unable to resolve dependency [{$parameter}] in class {$parameter->getDeclaringClass()->getName()}";
 
             throw new BindingResolutionException($message);
         }

diff --git a/tests/Container/ContainerCallTest.php b/tests/Container/ContainerCallTest.php
@@ -172,11 +172,22 @@ public function testCallWithCallableObject()
     public function testCallWithoutRequiredParamsThrowsException()
     {
         $this->expectException(BindingResolutionException::class);
-        $this->expectExceptionMessage('Unresolvable dependency resolving [Parameter #0 [ <required> $foo ]] in class Illuminate\Tests\Container\ContainerTestCallStub');
+        $this->expectExceptionMessage('Unable to resolve dependency [Parameter #0 [ <required> $foo ]] in class Illuminate\Tests\Container\ContainerTestCallStub');
 
         $container = new Container;
         $container->call(ContainerTestCallStub::class.'@unresolvable');
     }
+
+    public function testCallWithoutRequiredParamsOnClosureThrowsException()
+    {
+        $this->expectException(BindingResolutionException::class);
+        $this->expectExceptionMessage('Unable to resolve dependency [Parameter #0 [ <required> $foo ]] in class Illuminate\Tests\Container\ContainerCallTest');
+
+        $container = new Container;
+        $foo = $container->call(function ($foo, $bar = 'default') {
+            return $foo;
+        });
+    }
 }
 
 class ContainerTestCallStub