Skip to content

Commit

Permalink
[10.x] Illuminate\Filesystem\join_paths(): Argument #2 must be of typ…
Browse files Browse the repository at this point in the history
…e string, null given (#49467)

* + Added test that reproduces bug

* + Added fix that resolves bug

* Update src/Illuminate/Filesystem/functions.php

Co-authored-by: Mior Muhammad Zaki <[email protected]>

* Update src/Illuminate/Filesystem/functions.php

Co-authored-by: Mior Muhammad Zaki <[email protected]>

* ~ Don't explicitly test for null

---------

Co-authored-by: Mior Muhammad Zaki <[email protected]>
  • Loading branch information
tylernathanreed and crynobone authored Dec 21, 2023
1 parent 1652608 commit 1a84e34
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Illuminate/Filesystem/functions.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* @param string ...$paths
* @return string
*/
function join_paths($basePath, string ...$paths)
function join_paths($basePath, ...$paths)
{
foreach ($paths as $index => $path) {
if (empty($path)) {
Expand Down

0 comments on commit 1a84e34

Please sign in to comment.