[1.x] Mark password args as sensitive in ConfirmPassword
#578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
reviewed
Nov 20, 2024
| @@ -32,7 +32,7 @@ public function __invoke(StatefulGuard $guard, $user, ?string $password = null) | |||
| * @param string|null $password | |||
| * @return bool | |||
| */ | |||
| protected function confirmPasswordUsingCustomCallback($user, ?string $password = null) | |||
| protected function confirmPasswordUsingCustomCallback($user, #[\SensitiveParameter] ?string $password = null) | |||
There was a problem hiding this comment.
This version requires PHP 8.1 as minimum and SensitiveParameter is available on PHP 8.2 and above.
Need to require https://github.com/symfony/polyfill-php82 if we want to merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid revealing any sensitive details in a stack trace.