Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Recently I had a situation where I needed to choose a different length for the 2FA recovery codes and provide them as lowercase. As
RecoveryCode::generate()
is called statically in TwoFactorAuthenticatable, EnableTwoFactorAuthentication and GenerateNewRecoveryCodes I had to extend those classes to be able to call my own RecoveryCode class.This PR aims to fix that paper cut by allowing developers to (optionally) define how recovery codes are generated by calling a new
RecoveryCode::generateRecoveryCodeUsing()
method and providing a callback. For example:Another way so solve this issue might be to bind the RecoveryCode class to the container with a contract so it can be rebound, but this felt simpler and is a pattern used in other places within Laravel (ResetPassword::createUrlUsing() for example) however happy to go that route if it is preferred.