[1.x] Ensure logout route is authenticated #536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently possible to hit the
/logout
route as a guest. This means that the auth system "logs out" anull
user.This can occur in the real world when you:
The framework will now logout a
null
user.I believe this is a good fix because:
laravel/breeze
does this, so it creates consistency for Jetstream and Fortify.This issue was raised because 2 users have run into this in Pulse when using Jetstream (laravel/pulse#364) and Laravel UI (laravel/pulse#324). Although we will also handle this better in Pulse, I believe this is a good fix to include in Fortify.
laravel/ui
fix: [4.x] Ensure logout requires authentication ui#269