Use the illuminate password rule #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although I'm not opposed, this is a breaking change for a minor release. You can't simply delete a class from a minor release. |
|
Try the master branch maybe? |
|
Or maybe better: re-send this without deleting the class and simply add a |
|
Thanks for the feedback dries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be nice if we use the Password rule that is available so we do not have seperate classes with different functionalities.
The
Illuminate\Validation\Rules\Passwordhas more functionality than the Fortify implementation. For example this rule has mixed case and compromised check available.