Allow specifying a prefix for route names #496
Conversation
|
@driesvints The changes on this PR affects Jetstream. How can I handle this case? |
|
@moisish gonna be honest here. There's a very slim chance this will ever get merged if it affects Jetstream. You can try marking this as ready for review but I expect it getting declined. |
|
Should I get the jetsteam changes done as well before I marked this ready? |
|
@moisish I don't know. I'd just mark this as ready so Taylor can give his opinion. |
|
/ Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions! If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response. |
|
@taylorotwell anything i can do to get this merged? |
The PR introduces a way of setting a prefix on the name of the routes.
The reason of the PR is if you are building an admin panel and you want to use fortify, it makes sense all the route names to be 'admin.' such as 'admin.login', 'admin.logout'. Especially when you have a frontend where it has it's own Authentication and you need to separate the routes
A new option has been added the config file which by default it keeps the existing behaviour.