Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TwoFactorDisabledResponse and TwoFactorEnabledResponse should implement their respective interfaces #492

Closed
wants to merge 1 commit into from
Closed

fix: TwoFactorDisabledResponse and TwoFactorEnabledResponse should implement their respective interfaces #492

wants to merge 1 commit into from

Conversation

BJTheCod3r
Copy link

  • This correction addresses the incorrect implementation of interfaces by TwoFactorDisabledResponse and TwoFactorEnabledResponse. Both classes currently implement the TwoFactorLoginResponse interface, but this fix introduces the appropriate implementations for their respective interfaces.

@BJTheCod3r
fix: TwoFactorDisabledResponse and TwoFactorEnabledResponse should im…
d7c6bae 
…plement their respective interfaces.

- This correction addresses the incorrect implementation of interfaces by TwoFactorDisabledResponse and TwoFactorEnabledResponse. Both classes currently implement the LoginResponse interface, but this fix introduces the appropriate implementations for their respective interfaces.
@taylorotwell
Copy link
Member

I think this would be a breaking change on a patch release.

@BJTheCod3r
Copy link
Author

I think this would be a breaking change on a patch release.

@taylorotwell I highly doubt this, but understandably, it's better safe than sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BJTheCod3r @taylorotwell