Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmable 2FA #357

Closed
wants to merge 6 commits into from
Closed

Confirmable 2FA #357

wants to merge 6 commits into from

Conversation

taylorotwell
Copy link
Member

@taylorotwell taylorotwell commented Feb 17, 2022

This PR allows 2FA to be configured to require confirmation before it is fully enabled via a new feature option. I don't think this PR is even required to be breaking with a few additional tweaks. But, sending to master for now.

Enabled via:

Features::twoFactorAuthentication(['confirm' => true])

@driesvints
Copy link
Member

I feel like we should be able to do this in Fortify v1. By default Features::optionEnabled(Features::twoFactorAuthentication(), 'confirm') will return false so it should not break any existing apps.

However, in Fortify 2.x I would set it to be enabled by default.

@driesvints driesvints mentioned this pull request Feb 18, 2022
@CyberPunkCodes
Copy link

CyberPunkCodes commented Feb 18, 2022

A very necessary PR to make Fortify usable with real-world customers 👍

Thank you very much for this. I haven't tested it, but so long as it works as advertised, it will make Fortify and it's children (Breeze, Jetstream, etc) complete!

@taylorotwell
Copy link
Member Author

#358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current 2FA solution can lock users out of their accounts
5 participants