Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#encryptedPrivate does not work with NullConnector #367

Closed
luniki opened this issue Jan 17, 2023 · 1 comment · Fixed by #369
Closed

#encryptedPrivate does not work with NullConnector #367

luniki opened this issue Jan 17, 2023 · 1 comment · Fixed by #369

Comments

@luniki
Copy link
Contributor

luniki commented Jan 17, 2023

  • Echo Version: 1.14.2
  • Laravel Version: na
  • PHP Version: na
  • NPM Version: na
  • Node Version: na

Description:

Calling echo.encryptedPrivate(…) while using a NullConnector results in an error:

Uncaught TypeError: this.connector.encryptedPrivateChannel is not a function

This is caused by line https://github.com/laravel/echo/blob/master/src/echo.ts#L107 as a NullConnector does not have an encryptedPrivateChannel function.

Steps To Reproduce:
luniki pushed a commit to luniki/laravel-echo that referenced this issue Jan 17, 2023
Add an encrypedPrivateChannel function to the NullConnector.
1fd4503 
Fixes laravel#367
@luniki luniki mentioned this issue Jan 17, 2023
Merged
@driesvints
Copy link
Member

Thanks, you sent in a PR so let's see how it goes.

taylorotwell pushed a commit that referenced this issue Jan 17, 2023
@luniki
Add an encrypedPrivateChannel function to the NullConnector. (#369)
9d156f7 
Fixes #367

Co-authored-by: Marcus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an encrypedPrivateChannel function to the NullConnector. luniki/laravel-echo
2 participants
@luniki @driesvints