Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#listenToAll for NullConnector #366

Closed
luniki opened this issue Jan 17, 2023 · 1 comment · Fixed by #368
Closed

#listenToAll for NullConnector #366

luniki opened this issue Jan 17, 2023 · 1 comment · Fixed by #368

Comments

@luniki
Copy link
Contributor

luniki commented Jan 17, 2023

  • Echo Version: 1.14.2
  • Laravel Version: na
  • PHP Version: na
  • NPM Version: na
  • Node Version: na

Description:

While #315 added support for #listenToAll for the PusherConnector, this functionality is missing in the NullConnector resulting in a echo.private(…).listenToAll is not a function.

In my project the connection to Pusher is optional so I have to use the NullConnector in that case.

Steps To Reproduce:
luniki pushed a commit to luniki/laravel-echo that referenced this issue Jan 17, 2023
Add a listenToAll function the NullConnector.
33f3c23 
Fixes laravel#366
@luniki luniki mentioned this issue Jan 17, 2023
Merged
luniki pushed a commit to luniki/laravel-echo that referenced this issue Jan 17, 2023
Add a listenToAll function the NullConnector.
8a863b6 
Fixes laravel#366
@driesvints
Copy link
Member

Thanks, you sent in a PR so let's see how it goes.

taylorotwell pushed a commit that referenced this issue Jan 17, 2023
@luniki
Add a listenToAll function the NullConnector. (#368)
215186e 
Fixes #366

Co-authored-by: Marcus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a listenToAll function to the NullConnector. luniki/laravel-echo
2 participants
@luniki @driesvints