Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Added declined and declined_if validation rule documentation #7425

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

Frozire
Copy link
Contributor

@Frozire Frozire commented Nov 11, 2021

Adds declined and declined_at validation rules to the documentation

Should only be merged if feature PR (laravel/framework#39579) is merged.

Laravel PR: laravel/laravel#5723
Framework PR: laravel/framework#39579

We are running a financial application where users answer yes, and no selectors, such as are you registered as a bad payer or if do you have existing debt. We could solve our issue by reversing the question's phrasing, e.g. "not_registered_as_a_bad_payer", and using accepted but this reduces intent.

At the same time, we allow financial instances to select their configurations of what they allow or disallow. This rule could help us align validation closer to the original intent and limit developer or interpretation errors when used to compare each input to each business's configuration; simply by avoiding a "semi-double negative".

@Frozire Frozire changed the title Added declined and declined_if validation rule documentation [8.x] Added declined and declined_if validation rule documentation Nov 11, 2021
@taylorotwell taylorotwell marked this pull request as draft November 11, 2021 14:20
@taylorotwell
Copy link
Member

I will revisit this on Tuesday (release day).

@taylorotwell taylorotwell marked this pull request as ready for review November 16, 2021 15:08
@taylorotwell taylorotwell merged commit e5a6585 into laravel:8.x Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants