Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Fix duplicate password fields #332

Merged
merged 2 commits into from
Nov 24, 2023
Merged

[1.x] Fix duplicate password fields #332

merged 2 commits into from
Nov 24, 2023

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented Nov 24, 2023

Fixed

  • When visiting the profile page Breeze generates, there are a couple of warnings in the DevTools related to multiple elements using the same ID (see screenshot). Since these inputs are all displayed in the same page, they must use different DOM IDs.
Screenshot

before
image

after
image

@tonysm tonysm changed the title Fix duplicate password fields [1.x] Fix duplicate password fields Nov 24, 2023
@taylorotwell taylorotwell merged commit 60f339c into laravel:1.x Nov 24, 2023
16 checks passed
@tonysm tonysm deleted the fix-duplicate-ids branch November 24, 2023 15:43
@edcheyjr edcheyjr mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonysm @taylorotwell