Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Better Support for RTL #327

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

joelbutcher
Copy link
Contributor

Refactoring PR to align RTL support with Jetstream, following the merge of laravel/jetstream#1392.

Similar to the PR to Jetstream, these changes have been applied:

  • Replace ml-x with ms-x and mr-x with me-x
  • Replace pl-x with ps-x and pr-x with pe-x
  • Replace text-left with text-start and text-right with text-end
  • Replace left-0 with start-0 and right-0 with end-0
  • Apply ltr: and rtl: modifiers for the dropdown components (.e.g ltr:origin-top-left rtl:origin-top-right)

Testing
I've tested each stack locally by adding the dir="rtl" attribute to the body element in both the guest and app layouts. Content appears to align correctly in these formats.

@taylorotwell taylorotwell merged commit 8757692 into laravel:1.x Nov 1, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants