Set application home URI to /dashboard #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the application home to /dashboard since the /home URI does not exist by default but /dashboard exists on the Breeze Next.js example app. Alternatively, this could be set to "/" as this URL should be available on most apps. This then will be used by the VerifyEmailController for redirection to config('app.frontend_url').RouteServiceProvider::HOME.'?verified=1'.
This was referenced Oct 31, 2022
slimani-dev
pushed a commit
to slimani-dev/breeze
that referenced
this pull request
Jan 21, 2023
Set the application home to /dashboard since the /home URI does not exist by default but /dashboard exists on the Breeze Next.js example app. Alternatively, this could be set to "/" as this URL should be available on most apps. This then will be used by the VerifyEmailController for redirection to config('app.frontend_url').RouteServiceProvider::HOME.'?verified=1'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, when email verification is enabled on the API/Next.js stack, the email verification links with the default URI structure (
http://localhost:8000/verify-email/xx/xx?expires=xx&signature=xx) redirect tohttp://locahost:3000/home?verified=1which does not exist and thus, a 404 page gets rendered.This MR sets the application home URI to
/dashboardas a more reasonable default value since the/homeURI does not exist by default but/dashboardexists on the Breeze Next.js example app. Alternatively, this could be set to/as this URL should be available on most apps. This then will be used by theVerifyEmailControllerfor redirection toconfig('app.frontend_url').RouteServiceProvider::HOME.'?verified=1'.