[1.x] Remove "Breeze" component prefix #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewmw5
pushed a commit
to drewmw5/breeze
that referenced
this pull request
Nov 11, 2022
* Remove Breeze prefix from components * Standardize layout components * Rename components that conflict with HTML elements
slimani-dev
pushed a commit
to slimani-dev/breeze
that referenced
this pull request
Jan 21, 2023
* Remove Breeze prefix from components * Standardize layout components * Rename components that conflict with HTML elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to laravel/jetstream#1117, the PR removes the "Breeze" prefix from the component imports in the Vue stack to give users a better sense of ownership over the scaffolding.
Additionally, I've renamed the
AuthenticatedandGuestlayout components toAuthenticatedLayoutandGuestLayoutrespectively. This makes the component names match the name they are imported with. The React stack was missing the suffix on the import, so I've added this in, which I think makes it much clearer in the template section.As with laravel/jetstream#1117, after the rename, there were some components that overlapped with native HTML elements. While this works in practice, Evan You recommends against it, so I've renamed the following components:
Button->PrimaryButtonInput->TextInputLabel->InputLabelWhile this isn't strictly required with the Blade stack, I've also renamed the components there for consistency.
The Jetstream PR explains the motivation behind these choices a little more.