Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

used typescript, added route handler, removed src directory #43

Closed
wants to merge 1 commit into from

Conversation

coolpraz
Copy link

@coolpraz coolpraz commented Mar 9, 2024

  • used typescript
  • added nextjs 14 route handler to encapsulate backend api and create extra layers between frontend and backend
  • removed src directory
  • updated dependencies to latest

const [email, setEmail] = useState<string>('')
const [password, setPassword] = useState<string>('')
const [passwordConfirmation, setPasswordConfirmation] = useState<string>('')
const [errors, setErrors] = useState<{ [key: string]: string[] }>({})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Record<string, string[]>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't got this one

@taylorotwell
Copy link
Member

I'm honestly not sure I will have the time or bandwidth to review this and make sure it's totally correct.

@vahidalvandi
Copy link
Contributor

@taylorotwell please accept #43 because typescript is very important thing for develop project with other uilibrary like charkra ui or next js ui

@pvujic
Copy link

pvujic commented Apr 18, 2024

@vahidalvandi Even though it wasn't merged, sadly, I want to thank you for the contribution. It helped me with the linting issues and saved me a lot of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants