-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow RocketChatAttachment class accept DateTimeImmutable as timestamp argument #9
Allow RocketChatAttachment class accept DateTimeImmutable as timestamp argument #9
Conversation
a9fa2ad
to
58ac0d6
Compare
I think we could separate this method on 2 strict typed methods:
|
It's pretty common for laravel to accept mixed types (eg, a date string or a |
@atymic yeah, but |
RocketChat also accepts DATE_ATOM timestamp, so I changed the code to using that. Then DateTimeInterface works fine |
I've replaced ATOM with RFC3339 because its name of the standard (their values are same). |
This PR adds failing tests for DateTimeImmutable timestamp. This need to be fixed.