Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor public API #7

Merged
merged 7 commits into from
Feb 22, 2020
Merged

Refactor public API #7

merged 7 commits into from
Feb 22, 2020

Conversation

antonkomarev
Copy link
Collaborator

@antonkomarev antonkomarev commented Feb 22, 2020

This PR contains:

  • renaming create static methods to make because all it does - instantiates (making) new instance, and not persisting (creating) anything;
  • renaming RocketChat::channel() to RocketChat::getDefaultChannel() to make its meaning more explicit;
  • renaming RocketChatAttachment::setFromArray to RocketChatAttachment::setPropertiesFromArray to make its meaning more explicit;
  • adds get prefix to all accessor methods;
  • drops RocketChat::url() accessor since it's not meant to be used outside of the class.

@antonkomarev antonkomarev added the enhancement New feature or request label Feb 22, 2020
@antonkomarev antonkomarev merged commit 27da688 into master Feb 22, 2020
@antonkomarev antonkomarev deleted the refactor-public-api branch February 22, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant