Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
create
static methods tomake
because all it does - instantiates (making) new instance, and not persisting (creating) anything;RocketChat::channel()
toRocketChat::getDefaultChannel()
to make its meaning more explicit;RocketChatAttachment::setFromArray
toRocketChatAttachment::setPropertiesFromArray
to make its meaning more explicit;get
prefix to all accessor methods;RocketChat::url()
accessor since it's not meant to be used outside of the class.