Attachment support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 21, 2020 09:56
drop support of laravel 5.5 in travis
Funfare
commented
Feb 21, 2020
| namespace NotificationChannels\RocketChat; | ||
|
|
||
| final class RocketChatMessage |
There was a problem hiding this comment.
Would not recommend final. We don't know what the user does, I see no problem with allowing to inherit from that class
There was a problem hiding this comment.
If it will be a problem - user will open an issue and describe a problem. We can remove final and it wouldn't be a breaking change. But you cannot do opposite thing without breaking changes.
added 3 commits
February 21, 2020 10:33
|
@Funfare squash & merge PRs with more than 1 commit, please. It's much easier to track down commit log when you are working this way. |
| * | ||
| * @return $this | ||
| */ | ||
| public function clearAttachments(): self |
There was a problem hiding this comment.
Why do we need this method?
Opened discussion in #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added support for attachments and more options to a message (alias, avatar, emoji) and changed the readme.
Think you can close the PR in the old repository.