Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

Changed buildUniqueExclusionRules to search for 'unique:' rather than 'unique' so that custom rules are not changed #231

Closed
wants to merge 3 commits into from

Conversation

brandonocasey
Copy link

  1. Fixed Mixed tabs and spaces in this file.
  2. Updated buildUniqueExclusionRules so that it searches for 'unique:' rather than just 'unique'

Example (see https://github.com/felixkiss/uniquewith-validator)
This Rule:
'unique_with:traffic_groups,document_id'

Was being changed to:
'unique:traffic_groups,document_id,1,id'

but should not have been changed at all because it is custom

…idation with the word unique in it, such as unique_with. Rather than Ardent modifing the rule incorrectly.
…stom validation with the word unique in it, such as unique_with. Rather than Ardent modifing the rule incorrectly."

This reverts commit 3d1cd2e.
@intensite
Copy link

Hello,

I am experiencing problems with the combination of Ardent and uniquewith-validator.
Is this patch in the dev-master branch of Ardent yet?

@brandonocasey
Copy link
Author

It is not, but I am unsure why

@igorsantos07
Copy link
Member

You were partially right on #251: I would not be able to merge this :) I'll look at code style soon, so stuff will be ready for #268
However, it wasn't merged before because the maintainer had abandoned the project and I had no time to look at it. Sorry, man :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants