Simplify dropdown, add constructors, add docs #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmoulton
force-pushed
the
simplify-dropdown
branch
from
32bb9a2 to
5bc8770
Compare
|
any comments @dzhou121 ? |
jrmoulton
force-pushed
the
simplify-dropdown
branch
3 times, most recently
from
3e0d093 to
d1a28fb
Compare
jrmoulton
force-pushed
the
simplify-dropdown
branch
from
d1a28fb to
bd39c03
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the
dropdownconstructor function because it hides the fact that there are multiple constructors that you might want to use in different situations.