Rename Tabs to Tab for clarity in the tab
argument closures and in the method signature for tab_button
#593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the fact that it has an 's' suffix on the name confusing when trying to work out the undocumented
tab
function while working from thetab_navigation.rs
example.Here's the livestream from today when I was working with this bit of code, see time offset: 1:49:31
https://www.youtube.com/watch?v=Q2VvQnRnHFQ&t=6580s
compare these examples:
vs
and this screenshot, from the livestream, prior to making this commit.
and this change, from this PR:
https://github.com/lapce/floem/compare/main...hydra:floem:tab-navigation-example-naming-1?expand=1#diff-274a9e69291fc381bf841ad41b047acac861463d897f391b20c6ff42ce3bf02eL29-L30