Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Tabs to Tab for clarity in the tab argument closures and in the method signature for tab_button #593

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

hydra
Copy link
Contributor

@hydra hydra commented Sep 26, 2024

I found the fact that it has an 's' suffix on the name confusing when trying to work out the undocumented tab function while working from the tab_navigation.rs example.

Here's the livestream from today when I was working with this bit of code, see time offset: 1:49:31

https://www.youtube.com/watch?v=Q2VvQnRnHFQ&t=6580s

compare these examples:

let tabs: Vec<Tabs> = vec![Tab::General, Tab::Settings, Tab::Feedback]

vs

let tabs: Vec<Tab> = vec![Tab::General, Tab::Settings, Tab::Feedback]

and this screenshot, from the livestream, prior to making this commit.

image

and this change, from this PR:

https://github.com/lapce/floem/compare/main...hydra:floem:tab-navigation-example-naming-1?expand=1#diff-274a9e69291fc381bf841ad41b047acac861463d897f391b20c6ff42ce3bf02eL29-L30

@dzhou121 dzhou121 merged commit 4dbecc8 into lapce:main Sep 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants