Fix text input cursor jumping to the end #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See lapce#532 (comment) for the explanation of what this PR fixes. This PR fixes it by adding a "cache" of the previous state of the buffer that skips updating the cursor position if the buffer is the same after the update
|
Thanks for working on it. But there's plan to replace the current |
|
Having only one text editor view seems like a great idea. Should this be merged nonetheless to fix programs using main? |
|
Makes sense, since we don't know when the new text input will be implemented :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #532
See #532 (comment) for the explanation of what this PR fixes.
This PR fixes it by adding a "cache" of the previous state of the buffer that skips updating the cursor position if the buffer is the same after the update.
Ideally there should be a way to distinguish updates "from inside" and updates "from outside", so that the effect could simply not be run.