Add create_signal_from_stream function #545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a better implementation of create_signal_from_tokio_channel:
Option
(if no initial value is available, it is easy to map the stream to wrap values in aSome
withStreamExt::map
Send
Overall is there a plan for async interop in floem? I wonder if I should implement an API like Leptos' resource API next.
add example ( a version of the timer that instead uses a tokio stream)
add test for the infinite loop case I'm worried about:
Basically it's checking that using the following stream implementation in
tokio-timer
does not lead to an infinite loop, but I'm not sure how to make it into a test. It works with the current version, but I'm afraid that it would be possible that a future change to the reactive system could break this.