The most minimal fix possible for inter-window messages not being processed #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessed Addresses lapce#463 in the absolutely most minimal way possible - just loop over all windows and process any pending events at the end of event processing for any window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #463 in the absolutely most minimal way possible - just loop over all windows and process any pending events at the end of event processing for any window.
Does not seem harmful - it would add some minimal overhead to each trip through the event-loop, but thinking it through, I'm not sure there's a way to avoid that which would not be incorrect in some cases.
I could even imagine a more aggressive version which loops over all windows until no window has anything to do (it is still imaginable that window A adds a message for window B and window B processes it adding a message for window A, and so forth, and whichever message is last still has to wait for the next event to jog the event loop).
However, that seems more invasive than a minimal fix for the observed behavior, which this is.