deps: kurbo is used via peniko. #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Noticed this when looking at your branch that replicates the |
|
peniko 0.1.0 doesn't give the options to turn on serde feature on kurbo. That's why we had to use kurbo directly. |
|
I see. The current |
Yes! |
|
@dzhou121 I have brought it up on the Zulip: https://xi.zulipchat.com/#narrow/stream/260979-kurbo/topic/New.20release.20of.20peniko.3F |
Since all usages of `kurbo` are via `peniko`, the direct dependency on `kurbo` is not needed. This makes it easier to keep versions in sync. The re-export of `kurbo` was happening directly so it could have been out of sync with an updated `peniko`, so re-export the version from `peniko` instead. `kurbo` was being used to enable the `serde` feature in it, so do that now via `peniko` as allowed in v0.1.1.
waywardmonkeys
force-pushed
the
remove-direct-kurbo-dependency
branch
from
3105a9b
to
8792cd1
Compare
|
Okay, |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all usages of
kurboare viapeniko, the direct dependency onkurbois not needed. This makes it easier to keep versions in sync.The re-export of
kurbowas happening directly so it could have been out of sync with an updatedpeniko, so re-export the version frompenikoinstead.