Expose setting a Window Icon #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewizzy
commented
May 22, 2024
Based on discussion this is reasonable and makes most sense.
|
It should be noted from where the icon comes from and what licence it is under or the icon should be replaced with one that doesn't require attribution/licence (for example Ferris could be used like in #116) |
The original icon.png had unknown origins, prior to inclusion in winit. Replaced with assets that were already in the repository and do not require attribution per lapce#116 (comment)
Absolutely. I have updated it to use a copy of existing assets that you mentioned. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to set a window icon is available in floem-winit but it isn't exposed through floem. This allows the floem dev to set a window icon as part of the window configuration.
There is an example included and it borrows heavily from the floem winit window_icon example - including the same icon file.