Start to add custom style methods for widgets #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmoulton
force-pushed
the
add-custom-style-methods
branch
from
e3993df to
3fde400
Compare
jrmoulton
force-pushed
the
add-custom-style-methods
branch
from
3fde400 to
326b7fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More convenient and consistent way to set custom properties. This also significantly improves the documentation experience for these custom properties. I initially tried to integrate with the regular style method but I didn't want to use extension traits that needed to be imported.
I've added these for a few widgets but I think it would be a good idea to have something similar for all widgets with custom properties