Add recapture button to inspector #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you mean the |
That's what I meant, thanks for clarifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds a 'Recapture' button to the inspector view:
(Q: should it be 'Refresh'? Should the button be smaller? Should it just be a refresh icon, but then we have to package a small svg?)
This is useful in scenarios where you want to recapture without interacting with the primary window itself.
An example is a focus issue in Lapce that I'm debugging, where I expect the focus is ending up somewhere it shouldn't, but if I want to trigger the inspector then I need the focus elsewhere. So I can't find out where the focus ends up! Recapture lets me interact with the primary window, recapture, and see where the focus is at.
Why this is a draft pr is that there's a bug with this code where sometimes when pressing recapture it will produce a blank screen, for reasons I don't know.