Stack event handlers #304
Stack event handlers #304
Conversation
src/views/decorator.rs
Outdated
| @@ -96,41 +96,47 @@ pub trait Decorators: View + Sized { | |||
| /// | |||
| /// NOTE: View should have `.keyboard_navigable()` in order to receive keyboard events | |||
| fn on_key_down( | |||
There was a problem hiding this comment.
on_key_down and on_key_up are already stackable.
There was a problem hiding this comment.
I removed the handlers from view data and made them just work like all of the other event handlers. Is there a reason to leave it this way?
There was a problem hiding this comment.
Yes. They have less startup cost as they directly mutate ViewData and don't need to send an update message.
There was a problem hiding this comment.
Should any other events be implemented with handlers in ViewData?
There was a problem hiding this comment.
I'd move as many as possible to use ViewData.event_handlers. Just have to be careful to not change behavior. I'd probably add a ViewData::add_event_handler method which boxes and pushes the handler for convenience.
Keep that in a separate PR if you give it a shot.
jrmoulton
force-pushed
the
add-stacking-handlers
branch
from
96c7031
to
3716e0d
Compare
No description provided.