-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LNK-3055: Hot Fix for Ambiguous call to operator error #538
Conversation
…e overload functions
WalkthroughThe changes in this pull request involve the addition of a new dependency to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
Java/measureeval/pom.xml (1)
98-102
: Consider moving version to property management.The dependency addition aligns with the PR objective to fix the ambiguous call operator error. However, for better maintainability, consider defining the version in the parent POM's property management section.
+ <!-- In parent pom.xml --> + <properties> + <cql.engine.version>3.15.0</cql.engine.version> + </properties> <!-- In this pom.xml --> <dependency> <groupId>info.cqframework</groupId> <artifactId>engine</artifactId> - <version>3.15.0</version> + <version>${cql.engine.version}</version> </dependency>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
Java/measureeval/pom.xml
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Java/measureeval/pom.xml (1)
Pattern **
: PRs that have "TECH-DEBT" in the title should only contain changes related to typos, unused code, linter/IDE suggestions, swagger specification updates, and logging improvements. These TECH-DEBT PRs should not affect core functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and approved, because I'm sure you're way more familiar that I am with what has changed between 3.12.0 and 3.15.0. (I assume no incompatibility gotchas with bumping just the one dependency?) I am curious, though ... does this fix something that we could have potentially run into by attempting to evaluate certain CQL? Any upstream issue/PR with more details that you could link to?
@c-schuler , explained to Steven via slack some of the dynamics being addressed by this. The other measure I tested against, the debug logging needs, and the issue with the latest version we found. Go ahead and merge after the branch is updated. |
🛠 Description of Changes
Reverted to a previous CQL Engine version to avoid ambiguity error with QiCore overload functions
🧪 Testing Performed
Performed local testing with CMS 506 and test packages using the FileSystemInvocation CLI
Summary by CodeRabbit
New Features
Chores