Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNK-3055: Hot Fix for Ambiguous call to operator error #538

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

c-schuler
Copy link
Contributor

@c-schuler c-schuler commented Nov 5, 2024

🛠 Description of Changes

Reverted to a previous CQL Engine version to avoid ambiguity error with QiCore overload functions

🧪 Testing Performed

Performed local testing with CMS 506 and test packages using the FileSystemInvocation CLI

Summary by CodeRabbit

  • New Features

    • Introduced a new dependency for enhanced functionality in the measureeval project.
  • Chores

    • Updated project configuration to include the latest version of the engine library.

Copy link
Contributor

coderabbitai bot commented Nov 5, 2024

Walkthrough

The changes in this pull request involve the addition of a new dependency to the pom.xml file of the measureeval project. The new dependency from the info.cqframework group, specifically the engine artifact with version 3.15.0, is included among the existing dependencies without altering any other configurations or sections of the file.

Changes

File Change Summary
Java/measureeval/pom.xml Added new dependency: <dependency> for info.cqframework:engine:3.15.0.

Possibly related PRs

Suggested reviewers

  • seanmcilvenna
  • smailliwcs

Poem

In the meadow where we play,
A new dependency came our way.
With engine now in our mix,
Our project grows, oh what a fix!
Hopping high, we cheer with glee,
For code that blooms like a springtime tree! 🌼🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
Java/measureeval/pom.xml (1)

98-102: Consider moving version to property management.

The dependency addition aligns with the PR objective to fix the ambiguous call operator error. However, for better maintainability, consider defining the version in the parent POM's property management section.

+ <!-- In parent pom.xml -->
+ <properties>
+     <cql.engine.version>3.15.0</cql.engine.version>
+ </properties>

  <!-- In this pom.xml -->
  <dependency>
      <groupId>info.cqframework</groupId>
      <artifactId>engine</artifactId>
-     <version>3.15.0</version>
+     <version>${cql.engine.version}</version>
  </dependency>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d9c8842 and 93f4fe7.

📒 Files selected for processing (1)
  • Java/measureeval/pom.xml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Java/measureeval/pom.xml (1)

Pattern **: PRs that have "TECH-DEBT" in the title should only contain changes related to typos, unused code, linter/IDE suggestions, swagger specification updates, and logging improvements. These TECH-DEBT PRs should not affect core functionality.

Java/measureeval/pom.xml Show resolved Hide resolved
Copy link
Contributor

@smailliwcs smailliwcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and approved, because I'm sure you're way more familiar that I am with what has changed between 3.12.0 and 3.15.0. (I assume no incompatibility gotchas with bumping just the one dependency?) I am curious, though ... does this fix something that we could have potentially run into by attempting to evaluate certain CQL? Any upstream issue/PR with more details that you could link to?

@seanmcilvenna
Copy link
Contributor

seanmcilvenna commented Nov 7, 2024

@c-schuler , explained to Steven via slack some of the dynamics being addressed by this. The other measure I tested against, the debug logging needs, and the issue with the latest version we found. Go ahead and merge after the branch is updated.

@seanmcilvenna seanmcilvenna changed the title LNK-3055 Hot Fix for Ambiguous call to operator error LNK-3055: Hot Fix for Ambiguous call to operator error Dec 11, 2024
@seanmcilvenna seanmcilvenna merged commit 1dec6a5 into dev Dec 11, 2024
17 of 22 checks passed
@seanmcilvenna seanmcilvenna deleted the LNK-3055-hot-fix-ambiguous-overload branch December 11, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants