Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake updates #46

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

CMake updates #46

wants to merge 7 commits into from

Conversation

mauneyc-LANL
Copy link
Collaborator

Lots has changed in how we build, so I've made some fixes. This isn't a complete redo of the build, which we should do but this shouldn't be too much work.

  • Removed ::flags and ::hdf5 flags
  • explicit target names singularity-opac
  • CMake formatting
  • ports-of-call submodule update (do we need spiner for this project?)

@mauneyc-LANL mauneyc-LANL requested a review from jonahm-LANL July 22, 2023 16:10
@mauneyc-LANL
Copy link
Collaborator Author

The CI probably needs some attending too:

Run sudo apt-get install -y --force-yes -qq build-essential libhdf5-serial-dev
W: --force-yes is deprecated, use one of the options starting with --allow instead.
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/c/curl/libcurl4-openssl-dev_7.81.0-1ubuntu1.10_amd64.deb  404  Not Found [IP: 52.250.76.244 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Error: Process completed with exit code 100.

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this, @mauneyc-LANL ! Yes---we do need spiner for this project. I'll look at what's going on with the CI

@Yurlungur
Copy link
Collaborator

@mauneyc-LANL I fixed the CI tests are now failing for other reasons. Looks like missing (or changed?) include paths. Did you want to mess with it? Or should I take a look?

@mauneyc-LANL
Copy link
Collaborator Author

@jonahm-LANL Good bit of changes needed. Not exactly sure what the gray opaq test is doing yet, but everything else is moving.

There's still lots of work that needs to be done to get this in a state for a stand-alone distribution. I'm assuming that the immediate need is for a submodule, so some shortcuts when sorting out dependencies/definitions.

I would further like to discourage all devs from copy-pasting code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants