Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modification w.r.t. Darwin CentOS8 Upgrade #54

Merged
merged 20 commits into from
Dec 21, 2021
Merged

Modification w.r.t. Darwin CentOS8 Upgrade #54

merged 20 commits into from
Dec 21, 2021

Conversation

ktsai7
Copy link
Contributor

@ktsai7 ktsai7 commented Dec 21, 2021

PR Summary

  • update clang-format dependency
  • only do pages_check, not pages when it is triggered pipelines in CI
  • use singularity-eos instead of singularity-eos-deps spackage
  • some cleanups and reorg in .gitlab-ci.yml

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.

ktsai7 added 20 commits December 17, 2021 20:57
@ktsai7
update clang-format modules and only do pages_check when it is trigge…
509bf3c 
…red pipelines
@ktsai7
update spack env command
5020db1
@ktsai7
switch to singularity-eos spackge and added +doc variant
cccd52e
@ktsai7
Update .gitlab-ci.yml
68996b7
@ktsai7
fix typo
5c7515d
@ktsai7
+mpi
4c5819c
@ktsai7
add format dep
2155761
@ktsai7
--show-log-on-error --no-checksum --yes-to-all
60752c3
@ktsai7
^openmpi@${SINGULARITY_EOS_OPENMPI_VERSION}
2464327
@ktsai7
update path
336ef2f
@ktsai7
spack variants work with +/~ which already implies enable/disable
42dd868
@ktsai7
+tests
bb58d96
@ktsai7
only build overall package in build/test jobs
c47c140
@ktsai7
do not set permission during CI Spack
443ada0
@ktsai7
source local spack again
03aae3a
@ktsai7
need to pull in the base spackage setup in the install jobs
82829e7
@ktsai7
improve template for both test and install jobs
259f3c8
@ktsai7
fix syntax error
b849458
@ktsai7
formatting
40c37b9
@ktsai7
no need for this variable anymore
acf25a4
@ktsai7 ktsai7 requested a review from Yurlungur December 21, 2021 00:59
Yurlungur
Yurlungur approved these changes Dec 21, 2021
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we let @mauneyc-LANL look at the new singularity spackage? Or just merge in?

@ktsai7
Copy link
Contributor Author

ktsai7 commented Dec 21, 2021

well he is the one who added the singularity-eos spackage, so the logic is written by him

I added variants doc and format for pulling in the documentation and formatting dependencies

spack does +/~ with variants, ~enable_* seems kinda strange, so modified that...

@Yurlungur
Copy link
Collaborator

Let's just merge it then.

@Yurlungur Yurlungur merged commit ab67c65 into main Dec 21, 2021
@Yurlungur Yurlungur deleted the ktsai_CentOS8Upgrade branch December 21, 2021 01:08
@aematts aematts mentioned this pull request Aug 29, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@mauneyc-LANL mauneyc-LANL Awaiting requested review from mauneyc-LANL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktsai7 @Yurlungur