Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement workaround for table edge issue #53

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

As discussed on mattermost, implements a fix for the discovered issue where for some inputs within machine precision of the boundary of a table, eospac produces incorrect output.

While we haven't yet figured out what is going on (I'm working on a self-contained reproducer), I argue that this change is harmless and avoids the issue, so we should move forward with it in sesame2spiner.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.

@Yurlungur Yurlungur added the bug Something isn't working label Dec 1, 2021
@Yurlungur Yurlungur self-assigned this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants