-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable electron/ion subtables for SpinerEOS and EOSPAC backends #459
Conversation
While I was at it, I also finally updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! My only comment is, would it be helpful identifying in the docs which subtable corresponds to what SESAME table number?
Done. will merge as soon as tests pass. |
PR Summary
This MR is in support of partial ionization and is a follow up to #444 . Here we provide the ability to request tabulated electron and ion equations of state from the sesame database either through SpinerEOS or EOSPAC backends. To do so, I add a new enum
which can be passed into the tabulated EOS constructors.
Total
is the previous behavior and is the default.ElectronOnly
is the electron EOS andIonCold
is the ion. As before, EOS calls are in terms of ion mass density and either electron or ion temperature. Unlike Zpslit, the ionization fraction is implicit in the model. A given electron temperature automatically implies some ionization fraction. It doesn't need to be passed in.To enable the electron or ion tables for SpinerEOS, you must also enable them in
sesame2spiner
by settingfor that material. This will trigger
sesame2spiner
to interpolate the relevant sub-tables, as well as the total. This is an addition not a replacement. Total tables are still available withionization=true
.PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following:
when='@main'
dependencies are updated to the release version in the package.py