Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update #432

Merged
merged 7 commits into from
Nov 22, 2024
Merged

ci: update #432

merged 7 commits into from
Nov 22, 2024

Conversation

rbberger
Copy link
Collaborator

@rbberger rbberger commented Nov 15, 2024

PR Summary

  • add ATS2 jobs
  • update ATS4 to use %cce
  • enable CDash reporting to internal LANL CDash server
  • fixed a naming issue in the closure tests

Note: currently several CI jobs fail due to previous breakage.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge when ready @rbberger

@rbberger
Copy link
Collaborator Author

Waiting to see if @jhp-lanl can fix some of the remaining failures.

@jhp-lanl
Copy link
Collaborator

Sorry I didn't get to this yesterday. I'll look right now

@jhp-lanl
Copy link
Collaborator

I'm running into what I think is a proxy error. It may take me a while to debug

@jhp-lanl
Copy link
Collaborator

I think I found the error, but I'm unable to build (and I think I can't run the CI either on LANL machines).

I'd just merge this and I can try to tackle the CI issues when my proxy issues are resolved.

@jhp-lanl
Copy link
Collaborator

I was able to reproduce and fix the error on rocinante. I'm running the gitlab CI now. @rbberger one of us can merge when the gitlab CI passes

@rbberger rbberger merged commit 185c70c into main Nov 22, 2024
6 checks passed
@rbberger rbberger deleted the rberger/ci_update branch November 22, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants