Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update spackage #431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update spackage #431

wants to merge 2 commits into from

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur added the build Something to do with the build system label Nov 7, 2024
@Yurlungur Yurlungur requested a review from rbberger November 7, 2024 18:06
@Yurlungur Yurlungur self-assigned this Nov 7, 2024
@Yurlungur
Copy link
Collaborator Author

we waited too long on this, I will merge it after #444.

@Yurlungur
Copy link
Collaborator Author

(obviously that's on me.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Something to do with the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants