Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update C++ standard to 17 #407

Merged
merged 2 commits into from
Aug 15, 2024
Merged

update C++ standard to 17 #407

merged 2 commits into from
Aug 15, 2024

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Aug 15, 2024

PR Summary

It's finally time @mauneyc-LANL .

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur merged commit a0e544f into main Aug 15, 2024
5 checks passed
@Yurlungur Yurlungur deleted the jmm/cxx17 branch August 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants