-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sgerberding adding python eos #402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a one-line test to make sure the object can be created here:
https://github.com/lanl/singularity-eos/blob/main/test/python_bindings.py#L67
As you can see, there is no thought towards correctness of parameters, so it should be an easy addition
…esting for StiffGas in test/python_bindings.py
Co-authored-by: Jeff Peterson <[email protected]>
…larity-eos into sgerberding_adding_python_eos
Co-authored-by: Jeff Peterson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. I'll merge when the tests pass
Update copyright
PR Summary
Added StiffGas into module.cpp so that stiff gas can be called in python bindings.
Can be called using (for example):
PR Checklist
make format
command after configuring withcmake
.