-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various robustness additions to the Davis EOS #374
Conversation
@chadmeyer please review these changes and see if you agree with my approach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I defer to @chadmeyer 's comments. But other than what chad picked out I'm happy. Thanks for the fixes.
@chadmeyer I think I addressed all your comments. I'll give things another scan and make sure I didn't miss anything else silly, but I think this is good now. |
FYI - I added a few more robustness additions. Mainly I added an error to the I also added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me now!
PR Summary
Three primary additions to the Davis Reactants and Products EOS to make them more robust:
robust::ratio
function when dividing by densityPR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following: